Comments on: Which One Do You Prefer?

By: The Murder Mistery « Search And Destroy

The Murder Mistery « Search And Destroy — Thu, 14 Apr 2011 18:57:56 +0000

[...] short while ago Davy Brion posted the first Agatha QuickNet tests. The first version was the initial attempt, the second a [...]

By: kilfour

kilfour — Wed, 09 Dec 2009 11:36:12 +0000

I had been thinking about using factorymethods instead of classes to model the transitions, like so:
public IMetaTransition GetError() { return new MetaTransition { Precondition = () => lastProcessRequestsAsyncCompletedArgs != null, GenerateInput = () => lastProcessRequestsAsyncCompletedArgs, Execute = input => input.Error } } }
Which clears things up a little.
I couldn’t get this to work because there is no way to reference the method in the attribute parameter.
Except ofcourse if I used a magic string.

By: den Ben

den Ben — Wed, 09 Dec 2009 08:32:54 +0000

allright… i’ll bite

on second thought maybe I do prefer the 2nd version
the specs are clearer

the in-line MetaTransition classes are still ugly though

maybe it would help if you renamed them to GetResultsTransition and GetErrorTransition

By: Davy Brion

Davy Brion — Tue, 08 Dec 2009 08:26:16 +0000

i used to think Objective C had an ugly syntax

until i learned to understand it

By: den Ben

den Ben — Tue, 08 Dec 2009 08:25:09 +0000

beautiful code is amongst other things easily understandable
ugly code, in most cases, isn’t

I haven’t invested a lot of time in figuring out both versions, but if I had to do so I have a feeling I’d go for version 1…

…although I also have a feeling that would be the wrong one in your opinion

By: Davy Brion

Davy Brion — Tue, 08 Dec 2009 06:04:24 +0000

well, it’s not really about which version looks better or less ugly… it’s about which version can you (sort of) understand without someone explaining everything to you?

By: Thomas Eyde

Thomas Eyde — Tue, 08 Dec 2009 00:55:17 +0000

I agree, both versions are ugly:

Bad formatting, but that could be a blog limitation.

Long names and declarations, who has the time to read

ProcessRequestsAsyncCompletedArgs processRequestsAsyncCompletedArgs = null;

when this will do:

ProcessRequestsAsyncCompletedArgs completedArgs = null

And all that Spec-stuff? Too much magic for my taste. I don’t understand any of those tests / specifications.

By: den Ben

den Ben — Mon, 07 Dec 2009 20:03:34 +0000

I think both versions are butt ugly… although I can’t really give you a nice alternative.

If I really had to choose, I’d go for version 1 since the first line in version 2 makes me want to shut my system down and run away as fast as possible.