Comments on: Which One Do You Prefer? http://davybrion.com/blog/2009/12/which-one-do-you-prefer/ Trying to walk that thin line between intelligence and ignorance Wed, 08 Sep 2010 21:03:45 +0000 hourly 1 http://wordpress.org/?v=3.0.1 By: kilfour http://davybrion.com/blog/2009/12/which-one-do-you-prefer/comment-page-1/#comment-23130 kilfour Wed, 09 Dec 2009 11:36:12 +0000 http://davybrion.com/blog/?p=2019#comment-23130 I had been thinking about using factorymethods instead of classes to model the transitions, like so: <code> public IMetaTransition GetError() { return new MetaTransition { Precondition = () => lastProcessRequestsAsyncCompletedArgs != null, GenerateInput = () => lastProcessRequestsAsyncCompletedArgs, Execute = input => input.Error } } } </code> Which clears things up a little. I couldn't get this to work because there is no way to reference the method in the attribute parameter. Except ofcourse if I used a magic string. I had been thinking about using factorymethods instead of classes to model the transitions, like so:

public IMetaTransition GetError()
{
return new MetaTransition
{
Precondition = () => lastProcessRequestsAsyncCompletedArgs != null,
GenerateInput = () => lastProcessRequestsAsyncCompletedArgs,
Execute = input => input.Error
}
}
}

Which clears things up a little.
I couldn’t get this to work because there is no way to reference the method in the attribute parameter.
Except ofcourse if I used a magic string.

]]> By: den Ben http://davybrion.com/blog/2009/12/which-one-do-you-prefer/comment-page-1/#comment-23128 den Ben Wed, 09 Dec 2009 08:32:54 +0000 http://davybrion.com/blog/?p=2019#comment-23128 allright... i'll bite on second thought maybe I do prefer the 2nd version the specs are clearer the in-line MetaTransition classes are still ugly though ;) maybe it would help if you renamed them to GetResultsTransition and GetErrorTransition allright… i’ll bite

on second thought maybe I do prefer the 2nd version
the specs are clearer

the in-line MetaTransition classes are still ugly though ;)

maybe it would help if you renamed them to GetResultsTransition and GetErrorTransition

]]> By: Davy Brion http://davybrion.com/blog/2009/12/which-one-do-you-prefer/comment-page-1/#comment-23124 Davy Brion Tue, 08 Dec 2009 08:26:16 +0000 http://davybrion.com/blog/?p=2019#comment-23124 i used to think Objective C had an ugly syntax until i learned to understand it ;) i used to think Objective C had an ugly syntax

until i learned to understand it ;)

]]> By: den Ben http://davybrion.com/blog/2009/12/which-one-do-you-prefer/comment-page-1/#comment-23123 den Ben Tue, 08 Dec 2009 08:25:09 +0000 http://davybrion.com/blog/?p=2019#comment-23123 beautiful code is amongst other things easily understandable ugly code, in most cases, isn't I haven't invested a lot of time in figuring out both versions, but if I had to do so I have a feeling I'd go for version 1... ...although I also have a feeling that would be the wrong one in your opinion ;-) beautiful code is amongst other things easily understandable
ugly code, in most cases, isn’t

I haven’t invested a lot of time in figuring out both versions, but if I had to do so I have a feeling I’d go for version 1…

…although I also have a feeling that would be the wrong one in your opinion ;-)

]]> By: Davy Brion http://davybrion.com/blog/2009/12/which-one-do-you-prefer/comment-page-1/#comment-23121 Davy Brion Tue, 08 Dec 2009 06:04:24 +0000 http://davybrion.com/blog/?p=2019#comment-23121 well, it's not really about which version looks better or less ugly... it's about which version can you (sort of) understand without someone explaining everything to you? well, it’s not really about which version looks better or less ugly… it’s about which version can you (sort of) understand without someone explaining everything to you?

]]> By: Thomas Eyde http://davybrion.com/blog/2009/12/which-one-do-you-prefer/comment-page-1/#comment-23119 Thomas Eyde Tue, 08 Dec 2009 00:55:17 +0000 http://davybrion.com/blog/?p=2019#comment-23119 I agree, both versions are ugly: Bad formatting, but that could be a blog limitation. Long names and declarations, who has the time to read <code> ProcessRequestsAsyncCompletedArgs processRequestsAsyncCompletedArgs = null; </code> when this will do: <code> ProcessRequestsAsyncCompletedArgs completedArgs = null </code> And all that Spec-stuff? Too much magic for my taste. I don't understand any of those tests / specifications. I agree, both versions are ugly:

Bad formatting, but that could be a blog limitation.

Long names and declarations, who has the time to read


ProcessRequestsAsyncCompletedArgs processRequestsAsyncCompletedArgs = null;

when this will do:


ProcessRequestsAsyncCompletedArgs completedArgs = null

And all that Spec-stuff? Too much magic for my taste. I don’t understand any of those tests / specifications.

]]> By: den Ben http://davybrion.com/blog/2009/12/which-one-do-you-prefer/comment-page-1/#comment-23115 den Ben Mon, 07 Dec 2009 20:03:34 +0000 http://davybrion.com/blog/?p=2019#comment-23115 I think both versions are butt ugly... although I can't really give you a nice alternative. If I really had to choose, I'd go for version 1 since the first line in version 2 makes me want to shut my system down and run away as fast as possible. I think both versions are butt ugly… although I can’t really give you a nice alternative.

If I really had to choose, I’d go for version 1 since the first line in version 2 makes me want to shut my system down and run away as fast as possible.

]]>