Why I Dislike Classic Or Typical WCF Usage

25 commentsWritten on July 21st, 2009 by
Categories: Opinions, WCF

If you've ever used or read about WCF, you've most likely seen classic or typical WCF usage. With that i mean service contracts with various operations on them, service implementations that either contain logic or always delegate to other classes, generated client proxies that need to be kept in synch every time you add an operation to a service and a lot of repetitive XML in your configuration files. In some cases (usually for very specific services with limited functionality) there is nothing wrong with that. But for a service layer that sits on top of your business layer so it can be used by the front end of your application (be it ASP.NET, Silverlight, a WPF client or whatever) i find typical WCF usage to be far from ideal.

My biggest issue with typical WCF usage is that of service contract design. It's very hard to get this 'right' and most people simply don't. First of all, you need to decide between fine-grained and coarse-grained operations. Fine-grained operations typically lead to chatty communication between the client and the service, which could seriously impact performance and scalability. Then again, fine-grained operations do offer a lot of flexibility when it comes to reusing functionality in various parts in the client. Coarse-grained operations typically don't have the same negative effect on performance, but they can easily introduce implicit coupling between your service and the client which can get pretty annoying when you need to deal with a new kind of client, like a Silverlight application for instance (which tends to have different service usage patterns than typical ASP.NET applications). It can also lead to duplication when parts of functionality offered by a coarse-grained operation are needed somewhere else.

Even if you do get the granularity of your operations right, you have to figure out where to put them. Are you going to create a service for each kind of functional subdomain (billing, invoicing, registrations, etc...), for each entity that is 'known' to the client (there are many people who do this, unfortunately) or on a per-feature basis (story or use case driven)? Every possible variation you can think of is already being used today, and they almost always come with a lot of disadvantages. Get this part wrong and you can end up with clients that might need 2 or more service proxies just to show some related data on a screen (or worse, to complete a business transaction). Whether you get it right or wrong, odds are high that you'll have spent quite a bit of time defining your service contracts. Time that might have been better off being spent on other parts.

The second thing that bothers me a lot about typical WCF usage is the quality of the code in service implementations. In the worst cases, these classes actually contain true business logic to implement the service operations. That's not just breaking the Single Responsibility Principle, it's more like assaulting it. Whether they contain actual business logic or merely delegate to other classes, these service implementations will need to talk to instances of classes or components that they depend on sooner or later. My question is, where do these instances come from? Do you manually resolve them through your IOC container? Do you have them injected in your service instance (if creation of the service instance is controlled by an IOC container, that is)? What if the granularity of the service contract forces the service implementation to depend on components that might not be used together in all operations?

And then there's the thorny issue of cross cutting concerns within service implementations. How many times have you seen the same old tired logging and exception handling code repeated in every service operation? How about transaction handling, auditing, authorization or resource management? True, you can plug into WCF's extensibility model (if you're willing to look for it...) or use AOP tricks to minimize that kind of code duplication but that in turn limits your possibilities when you want to add just a little bit of custom code to some of the cross cutting concern's logic when needed. In most cases, service implementations simply contain a lot of smelly code, the large majority of which is essentially a form of waste.

That's already an important list of problems when designing and implementing typical WCF services. But what about using typical WCF services? This is somewhat problematic as well, IMHO. First of all, you'll need a proxy to access the service. You can either develop these proxies yourself, or you can generate them through visual studio, svcutil, or custom tools that you (or others) developed. Whatever way you choose to use, you can't escape the fact that you constantly have to keep those proxy implementations in synch with their respective service contract. Every single time one of the developers adds an operation to a service (which is pretty often once there are a few people working on a large project), you're going to have to do something to make sure you can access that operation through your proxy. It's usually not a lot of work, but it does kinda disrupt your coding flow. Over and over again. It can also be a pain in the ass when it comes to source control conflicts.

Then there's the actual matter of using the proxy instances. Can you implement your story or use case with just one client proxy type? Great! Do you reuse the channel when making multiple service calls? You do? Great! Do you make sure you handle faulted channels properly? And if you need multiple client proxy types (depending on your service contract granularity), are you aware of the fact that you are using multiple WCF channels (and yes, they are expensive) which are often kept open longer than they should be if you're not careful? Are you generally careful about chatty communication? Obviously, that last one depends on the contract of the service and not really the implementation of the client proxy. There are quite a lot of things you need to keep in mind when using these proxies.

My final thing on the list of 'dislikes' is the configuration that is required to use these services. For every service you expose you'll need to add some XML to your configuration file. Twice even (server and client)! Most of this XML configuration is extremely tedious and very repetitive which just invites minor mistakes to be made. Those minor mistakes could lead to a lot of debugging/problem solving time though.

I've been subjected to each and every one of the issues i've mentioned in projects that made typical use of WCF (or classic ASP.NET Web Services for that matter). This type of service layer implementation is, IMHO, hurtful for productivity, detrimental to code quality and i don't really like the implicit trade-off between reusability and performance/scalability (depending on the granularity of your operations).

About a year ago, i really wanted to figure out a way to implement services which would enable me to keep fine-grained operations on my service layer without having to pay the performance/scalability penalty for that. As some of you already know, that led to the whole WCF call batching thing (more info here and here) which i later on called the Request/Response Service Layer. Some people liked the approach, but i don't think anyone else actually uses it. At least, i've never heard of anyone using it in a real project.

Well obviously, we've been using this at work for about a year now and while i won't claim that it's perfect (hint: nothing is), it has worked very well for us in several projects. More specifically, this approach has offered us the following benefits, which heavily contrast all of the downsides of typical WCF usage that i listed above:

  • Since we only have one service contract with one service operation, we don't need to spend time thinking about how to design and implement our service contracts and our operations. After all, every operation that the service layer must support is a specific request type that can be added, together with its requesthandler.
  • We can keep our operations as fine-grained as we want (which increases reusability and overall flexibility), without having to pay the cost for chatty network communication by batching multiple requests per roundtrip as much as possible in a transparent manner.
  • The actual implementation of our service is very minimal. It's just a small class which resolves the appropriate requesthandler through the IOC container, based on the type of the incoming request. It then delegates to the requesthandler by passing the request to it, and it returns the response to the client. We can simply add 'operations' by adding request types and requesthandlers to our assemblies... everything gets registered automatically when the application starts up
  • We avoid repetitive code for cross cutting concerns by putting it in a base requesthandler class that the other ones inherit from. That kind of code now only occurs once, and we can plug in custom code at any point of the execution by simply using the Template Method pattern.
  • The implementation of our requesthandlers doesn't contain any code that doesn't have to be there. Each requesthandler simply implements the Handle method to handle the incoming request, and can do as it pleases to fulfill the request. All dependencies are injected automatically by the IOC container. It's usually nothing more than using the dependencies to execute the necessary business logic and then returning a response-derived object.
  • Since we only have one service, we only need one client proxy which never needs to be updated (technically, we have 2: one which is entirely asynch and mostly used in Silverlight clients, and one which is strictly synchronous and is mostly used by ASP.NET applications and Windows Services or command line tools.
  • This single client proxy implementation can make sure that underlying WCF resources are utilized as efficiently as possible and cleaned up properly throughout the client application(s).
  • The client proxy is easy to stub during unit tests which increases the testability of our client side code.
  • Very little configuration. We only have to configure one client-side endpoint, and one server-side endpoint. That's it.
  • All of this is very easy to put in some kind of reusable library. Our applications simply reference the library, inherit from the base requesthandler types, make sure everything is registered properly upon application startup, add a couple of lines of XML and we can start the development of our service layer without any friction.

The only downside to this approach that i can think of after using it for a year, is interoperability with other platforms. I haven't used it in that situation yet, and while i do think it can be made to work i don't think it'll be easy nor pretty.

Now, just to be clear: this entire post was not a rant against WCF. I actually do like WCF as a technology, it's just the typical usage patterns of WCF that i really dislike. I love the fact that WCF is very extensible, configurable and flexible, but i merely consider it as a communication technology. Nothing more, nothing less.

  • http://jack-fx.com Jack

    I also like the REST style. WCF also give a toolkit, but only a CTP version.

  • Marcus Rosen

    Hi,

    Is there a reason you are using a static proxy instead of the Channel Factory directly?

    Considering you control both the end-points wouldn’t a Channel Factory be simpler as all you need to do is share the contracts assembly instead of re-generating the proxy everytime you add/change an operation?

  • http://davybrion.com Davy Brion

    i’m going to assume that with ‘static proxy’ you mean a class which offers methods for each operation in the service contract… otherwise i’d have no idea where you got ‘static’ from

    dealing with channels requires some housekeeping code… if you don’t want to see that repeated throughout your codebase, you put that code in a class (in this case, the proxy type) and just use instances of that class.

  • Marcus Rosen

    By static I ment a proxy that was generated by the svcutil /WSDL tool.

  • Alex Simkin

    …but i don’t think anyone else actually uses it.

    We started to use it from the moment I read your blogpost :)

  • http://davybrion.com Davy Brion

    @Alex

    ah, cool! how has it worked out so far?

  • http://nirajrules.wordpress.com Niraj

    Hi Davy,

    Your design is interesting though I have my reservations about the value addition it does versus the complexity it brings. The main driving point for me in your arguments is – coarse / fine grained operations & both have their own disadvantages. I would still prefer going for coarse grained the reason being they are more explicit, easy to understand & consume. I agree it would add duplication of code (considering it might be duplicated for different clients / scenarios) but this duplication is more of instantiation & packing (not any algorthmic one). I would have fine grained repositories which inturn would create data & expose them through coarse grained contracts. Your solution looks like over engineering.

  • http://davybrion.com Davy Brion

    @Niraj

    the complexity is isolated within the infrastructural classes… the actual request handlers are as simple as they can be, so i don’t see why it would be over engineering ;)

  • Alex Simkin

    @Davy

    Pretty good. We have replaced Castle with Hiro and put our own implementation of KnowTypesProvider, but other than that, your code works just fine.

  • http://davybrion.com Davy Brion

    @Alex

    good to know :)

    if you ever run into problems with it or have any questions, just mail me

  • Pingback: Scott Banwart’s Blog » Blog Archive » Distributed Weekly 7

  • http://www.charliedigital.com Charles Chen

    This is an interesting solution.

    I’m torn as it does solve a very real problem, but at the same time, it hinders discovery of operations. To some extent, this is offset by the request classes, but there is a danger here of not knowing exactly how much data you need unless you create a request per call (whereas a method signature is much more explicit in terms of the parameterization).

  • http://www.bennymichielsen.be Benny Michielsen

    I’m actually using this approach in one of my projects and like it a lot. For interoperability with other classes I’d expose a service for that part of the system (i.e billing, customers,…) which internally will use the request handlers stuff as well.

  • http://www.bennymichielsen.be Benny Michielsen

    And with classes I mean clients.

  • Pingback: Request/Response Service Layer Series | The Inquisitive Coder – Davy Brion’s Blog

  • Pingback: Arjan’s World » LINKBLOG for Nov 18, 2009

  • SonOfPirate

    For what it’s worth, this is the model that Microsoft Dynamics uses for their web services in CRM (see CrmService). Seems like a pretty good endorsement.

  • kilfour

    @SonOfPirate
    Seems like a pretty good endorsement.
    ‘Seems’ being the keyword in above statement.
    I’m currently working on an application and I have a generated proxy in my project of almost 70.000 lines.
    Why ? Because I have to send a request to that CRM service to update a status field every once in a blue moon.

  • Pingback: Hey Microsoft, Our Databases Aren’t Services! | The Inquisitive Coder – Davy Brion's Blog

  • Pingback: Consuming An Agatha Service From A Non-Agatha-Aware Client | The Inquisitive Coder – Davy Brion's Blog

  • http://www.taeuber.org JT

    I think the approach has definitely some advantages.
    But you can do similar things by using a message routing service in WCF which routes the message to your fine-grained services based on the message (having one service as entry point for the others). In fact there is sample in the SDK. Apart from that: Let’s publish that kind of service over HTTP. Does the WSDL contain all the possible contracts?

    Another question comes into my mind: Why is stubbing/mocking a generic interface easier than stubbing/mocking the fine-grained interfaces? In order to mock the generic interface you described, you need to have implementation knowledge of the service.

    I share your view of the disadvantages of regular WCF usage though. But my current preference is using a RESTful service design.

  • http://davybrion.com Davy Brion

    @JT

    yes, the WSDL contains all the possible contracts:
    http://davybrion.com/blog/2010/05/consuming-an-agatha-service-from-a-non-agatha-aware-client/

    as for the stubbing/mocking being easier… typical WCF proxies are not generated with an interface and are not often used through an interface (unless you actually put in a bit of effort to do so). If you have many proxies, you need to do that for each proxy. With Agatha’s request dispatchers, you don’t need to do anything since they already implement an interface and you always use them through the interface

  • http://www.taeuber.org JT

    >yes, the WSDL contains all the possible contracts

    that’s great.

    > typical WCF proxies are not generated with an interface and are not often used through an interface (unless you actually put in a bit of effort > to do so).

    Normally you should extract an interface all the time, I consider that as best practice when working with WCF. Therefore it consider it easier to mock against an strongly-interface interface / contracts. In your case you need to know for example that HelloWorldRequest produces a HelloWorldResponse and this you cannot see in the contract. That is what I meant by knowledge of implementation details.

    In the end you put a facade in front of you fine-grained services (in agatha those are different request handlers). I programmed something similar building on WCF message contracts, basically the same goal in mind :P . But at the moment I have a deeper look into REST :)

  • http://profiles.google.com/danbarua Dan Barua

    Interesting!

    In my last project I used a Javascript framework called ExtJS with Asp.Net MVC acting essentially as lightweight webservices serving up snippets of JSON. ExtJS has a package called ExtDirect. What ExtDirect does is build up a Javascript client proxy using reflection to gather information about all your Controllers and their Actions. Calls, which can be batched, are then made via the client proxies to a DirectController which then instantiates your controllers and dispatches requests to them.

    I was wondering if anyone had implemented something similar for WCF and here it is. I look forward to diving into it.

  • Pingback: Using MEF in a Request/Response Service Layer « DarioSantarelli.Blog(this);