Comments on: Your Data Retrieval Code Should Be Readable Too http://davybrion.com/blog/2009/03/your-data-retrieval-code-should-be-readable-too/ inquisitive: adjective. given to inquiry, research, or asking questions; eager for knowledge; intellectually curious Wed, 08 Feb 2012 11:42:42 +0000 hourly 1 http://wordpress.org/?v=3.3.1 By: Weekly Links #44 | GrantPalin.comhttp://davybrion.com/blog/2009/03/your-data-retrieval-code-should-be-readable-too/comment-page-1/#comment-9952 Weekly Links #44 | GrantPalin.com Mon, 16 Mar 2009 02:30:53 +0000 http://davybrion.com/blog/?p=1072#comment-9952 [...] Your Data Retrieval Code Should Be Readable Too Good advice from Davy Brion. [...] [...] Your Data Retrieval Code Should Be Readable Too Good advice from Davy Brion. [...]

]]> By: Neal Blomfieldhttp://davybrion.com/blog/2009/03/your-data-retrieval-code-should-be-readable-too/comment-page-1/#comment-9679 Neal Blomfield Wed, 11 Mar 2009 01:15:38 +0000 http://davybrion.com/blog/?p=1072#comment-9679 Might not need the Lambda Extensions if the work on the AST is completed ( no idea what the timeframe on that is ), we'll just be able to bang out some good old fashioned LINQ =D Might not need the Lambda Extensions if the work on the AST is completed ( no idea what the timeframe on that is ), we’ll just be able to bang out some good old fashioned LINQ =D

]]> By: Davy Brionhttp://davybrion.com/blog/2009/03/your-data-retrieval-code-should-be-readable-too/comment-page-1/#comment-9660 Davy Brion Tue, 10 Mar 2009 20:23:23 +0000 http://davybrion.com/blog/?p=1072#comment-9660 yeah those lambda extensions are really nice, and if i'm not mistaken they will be included in NHibernate _after_ the 2.1 release (which might be NH3 but not sure on this)but i generally stick with what's in NH core yeah those lambda extensions are really nice, and if i’m not mistaken they will be included in NHibernate _after_ the 2.1 release (which might be NH3 but not sure on this)

but i generally stick with what’s in NH core

]]> By: Neal Blomfieldhttp://davybrion.com/blog/2009/03/your-data-retrieval-code-should-be-readable-too/comment-page-1/#comment-9659 Neal Blomfield Tue, 10 Mar 2009 20:19:00 +0000 http://davybrion.com/blog/?p=1072#comment-9659 Hmm, a few missing bits in that query - I forgot to encode the < / >=S Hmm, a few missing bits in that query – I forgot to encode the < / >

=S

]]> By: Neal Blomfieldhttp://davybrion.com/blog/2009/03/your-data-retrieval-code-should-be-readable-too/comment-page-1/#comment-9658 Neal Blomfield Tue, 10 Mar 2009 20:17:31 +0000 http://davybrion.com/blog/?p=1072#comment-9658 Not sure if you have tried NHibernate Lambda Extensions but they clean up the queries even more (and make them typesafe as well!)Using your example above, it would translate as soemthing like the following (without a test I wouldn't be 100% certain)<code> Team teamAlias = null; var teamIdsForUser = DetachedCriteria.For() .Add(u => u.Id == userId) .CreateAlias( u => u.Teams, () => teamAlias ) .SetProjection( LambdaProjection.Property( () => teamAlias.Id ) );Incident incidentAlias = null; Configuration configurationAlias = null; Structure structureAlias = null; var incidents = Session.CreateCriteria(typeof(Incident), () => incidentAlias) .CreateCriteria( () => incidentAlias.Configurations, () => configurationAlias, JoinType.InnerJoin) .CreateCriteria(() => configurationAlias.Structure, () => structureAlias, JoinType.InnerJoin) .Add(LambdaSubquery.Propery( () => configurationAlias.OrganisationalItem.Id ).In( teamIdsForUser )) .Add( () => incidentAlias.ApprovedPhase == structureAlias.Phase ) .Add(SqlExpression.IsNull( () => incident.EndDate ) .SetResultTransformer(CriteriaSpecification.DistinctRootEntity) .List(); </code>http://code.google.com/p/nhlambdaextensions/ Not sure if you have tried NHibernate Lambda Extensions but they clean up the queries even more (and make them typesafe as well!)

Using your example above, it would translate as soemthing like the following (without a test I wouldn’t be 100% certain)


Team teamAlias = null;
var teamIdsForUser = DetachedCriteria.For()
.Add(u => u.Id == userId)
.CreateAlias( u => u.Teams, () => teamAlias )
.SetProjection( LambdaProjection.Property( () => teamAlias.Id ) );

Incident incidentAlias = null;
Configuration configurationAlias = null;
Structure structureAlias = null;
var incidents = Session.CreateCriteria(typeof(Incident), () => incidentAlias)
.CreateCriteria( () => incidentAlias.Configurations, () => configurationAlias, JoinType.InnerJoin)
.CreateCriteria(() => configurationAlias.Structure, () => structureAlias, JoinType.InnerJoin)
.Add(LambdaSubquery.Propery( () => configurationAlias.OrganisationalItem.Id ).In( teamIdsForUser ))
.Add( () => incidentAlias.ApprovedPhase == structureAlias.Phase )
.Add(SqlExpression.IsNull( () => incident.EndDate )
.SetResultTransformer(CriteriaSpecification.DistinctRootEntity)
.List();

http://code.google.com/p/nhlambdaextensions/

]]> By: Davy Brionhttp://davybrion.com/blog/2009/03/your-data-retrieval-code-should-be-readable-too/comment-page-1/#comment-9629 Davy Brion Tue, 10 Mar 2009 06:47:44 +0000 http://davybrion.com/blog/?p=1072#comment-9629 i did... from the post:"You can hide the complexity of those queries in views or stored procedures but by doing that, you’re moving some very important details outside of your code. You’re introducing one more little hurdle the next developer will have to get over when trying to comprehend a certain piece of code which has to use that view or that stored procedure."though i have used both to deal with complex queries, i don't think it's a good solution i did… from the post:

“You can hide the complexity of those queries in views or stored procedures but by doing that, you’re moving some very important details outside of your code. You’re introducing one more little hurdle the next developer will have to get over when trying to comprehend a certain piece of code which has to use that view or that stored procedure.”

though i have used both to deal with complex queries, i don’t think it’s a good solution

]]> By: anonhttp://davybrion.com/blog/2009/03/your-data-retrieval-code-should-be-readable-too/comment-page-1/#comment-9628 anon Tue, 10 Mar 2009 06:42:56 +0000 http://davybrion.com/blog/?p=1072#comment-9628 Did you think about using Views to make the data access easier to read? Did you think about using Views to make the data access easier to read?

]]>